Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13 : use instanceOf property in SmtpPluginManager for exception message #105

Closed
wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 6, 2020

Signed-off-by: Abdul Malik Ikhsan [email protected]

Q A
QA yes

Description

Re-create zendframework/zend-mail#231 by @glensc Fixes #13

…xception message

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik samsonasik mentioned this pull request Aug 6, 2020
@glensc
Copy link
Contributor

glensc commented Aug 6, 2020

@samsonasik please preserve authorship of original commit. using git commit --amend --author for example. or just git fetch REPO_URL && git cherry-pick COMMIT, wget https://github.com/zendframework/zend-mail/pull/231.patch && git am 231.patch works as well.

@samsonasik
Copy link
Member Author

@glensc You can create separate PR instead, and I will close this PR

@glensc
Copy link
Contributor

glensc commented Aug 6, 2020

@samsonasik this applies to all PR's you carry over. so it's beneficial for you to learn how to do do this.

@samsonasik
Copy link
Member Author

I always mention the original author in the PR description, if original author want to use their own commit, they can create separate PR instead, and I will close the PR immediately.

@samsonasik
Copy link
Member Author

I know about cherry pick, rebase and their friends, and mostly that create conflict for migrated code. That's I don't have enough time!

If You Want to use your own commit as original author, just create separate PR and I will close this.

@weierophinney
Copy link
Member

I used the wget + git am technique from @glensc locally, and it merged without conflicts. I've now pushed that into the 2.12.x branch, making this PR obsolete.

@samsonasik samsonasik deleted the fix-13 branch August 6, 2020 14:35
@glensc
Copy link
Contributor

glensc commented Aug 7, 2020

@samsonasik PR body is not the same as git commit. I can use git without github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants