[2.14]: Fix: Fold long lines during SMTP communication #140
Commits on Mar 15, 2021
-
Fold long lines following RFC 5322 section-2.2.3
To deal with the 998/78 character limitations per line, long lines can be split into a multiple-line representation separated by CRLF + WSP; this is called "folding". Correct folding is particularly important for long header fields. Signed-off-by: Vlad Safronov <[email protected]>
-
Use Headers::FOLDING when folding
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Use fgets and detect partial line reads
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Add unit test for long header wrapping
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Refactor data reader in Protocol\Smtp to use Generator
This isolates the logic of handling incomplete reads to own unit. Signed-off-by: Elan Ruusamäe <[email protected]>
-
As the buffer max size is known, can check last byte with isset Signed-off-by: Elan Ruusamäe <[email protected]>
-
Test for max length of all SMTP data lines
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Move chunkedReader to a method
he method has no state, so therefore declared static. Ideally this should be a standalone class, perhaps in laminas-stdlib. Signed-off-by: Elan Ruusamäe <[email protected]>
-
Update chunk_split to use 997 for correct result
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Update test that header line with exact length is not wrapped
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Update test to require lines not to be empty
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Add MAX_LINE_LENGTH constant for magic 998 value
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Update test to use SmtpProtocol::MAX_LINE_LENGTH constant
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Introduce local variable and exccessively document the logic in the loop
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Rename MAX_LINE_LENGTH -> SMTP_LINE_LIMIT
Signed-off-by: Elan Ruusamäe <[email protected]>
-
Update test to expect Headers::FOLDING never change
Signed-off-by: Elan Ruusamäe <[email protected]>
