Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support added #63

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

Atul-glo35265
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@Atul-glo35265
Copy link
Contributor Author

This is blocked by laminas/laminas-http which is not compatible with php8.4.

There is already a PR for the same.
Once it is merged, tests will get passed and our PR can merge.

@fezfez
Copy link
Contributor

fezfez commented Oct 9, 2024

@Atul-glo35265
Copy link
Contributor Author

Signed-off-by: Atul-glo35265 <[email protected]>
Signed-off-by: Atul-glo35265 <[email protected]>
… and removing trailing spaces

Signed-off-by: Atul-glo35265 <[email protected]>
@Atul-glo35265
Copy link
Contributor Author

@gsteel, @samsonasik,
Please review this PR and do needful.

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsteel gsteel self-assigned this Oct 11, 2024
@gsteel gsteel added this to the 3.14.0 milestone Oct 11, 2024
@gsteel gsteel merged commit bd81695 into laminas:3.14.x Oct 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants