Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Support for PHP 8.0, Add Support for PHP 8.3 #74

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

glo71317
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@gsteel
Copy link
Member

gsteel commented Oct 18, 2023

Once #72 is merged, this patch can be rebased and CI should go green

@gsteel gsteel added this to the 2.17.0 milestone Oct 18, 2023
@Ocramius
Copy link
Member

@gsteel done

@gsteel gsteel changed the title PHP 8.3 support added Remove Support for PHP 8.0, Add Support for PHP 8.3 Oct 18, 2023
@gsteel
Copy link
Member

gsteel commented Oct 18, 2023

This patch is going to need more work. I don't know the details yet, but it looks like a bunch of #[ReturnTypeWillChange] attribs are required, a bump to ServiceManager, and dealing with deprecations there, and also fixing unnecessary reflection api calls.

@gsteel
Copy link
Member

gsteel commented Oct 18, 2023

Also, doesn't look like the mongodb extension for 8.3 is available yet

@glo71317
Copy link
Contributor Author

glo71317 commented Nov 2, 2023

@gsteel all issues fixed except - mongodb extension as mongodb extension php 8.3 is not available yet, Will have to wait or any otherway to do this?

psalm-baseline.xml Outdated Show resolved Hide resolved
psalm-baseline.xml Outdated Show resolved Hide resolved
psalm.xml Outdated Show resolved Hide resolved
src/SaveHandler/DbTableGatewayOptions.php Outdated Show resolved Hide resolved
src/SaveHandler/MongoDBOptions.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@gsteel
Copy link
Member

gsteel commented Nov 2, 2023

@gsteel all issues fixed except - mongodb extension as mongodb extension php 8.3 is not available yet, Will have to wait or any otherway to do this?

The mongodb extension can be installed via pecl:
https://github.com/laminas/laminas-session/blob/2.17.x/.laminas-ci/install-mongodb-extension-via-pecl.sh

@glo71317
Copy link
Contributor Author

glo71317 commented Nov 3, 2023

php

All tests passed except one which is failing due to mongodb extension

@glo71317 glo71317 requested a review from gsteel November 6, 2023 07:26
@glo71317
Copy link
Contributor Author

glo71317 commented Nov 7, 2023

@gsteel Can you please have a look the PR? Any action is required from our end.

@Ocramius
Copy link
Member

Ocramius commented Nov 8, 2023

Until MongoDB ext is released, nothing to do here, IMO.

@froschdesign
Copy link
Member

@glo71317 @Ocramius
There is script for it:

#!/bin/bash
PHP_VERSION="$1"
if ! [[ "${PHP_VERSION}" =~ 8\.2 ]]; then
echo "mongodb is only installed from pecl for PHP 8.2, ${PHP_VERSION} detected."
exit 0;
fi
set +e
pecl install mongodb
echo "extension=mongodb.so" > /etc/php/${PHP_VERSION}/mods-available/mongodb.ini
phpenmod -v ${PHP} -s cli mongodb

And this must be updated. Compare with: laminas/laminas-cache-storage-adapter-ext-mongodb#45

@glo71317
Copy link
Contributor Author

glo71317 commented Nov 9, 2023

@froschdesign Thanks for suggesting! @Ocramius Now PR got green now you can proceed for merging.

psalm-baseline.xml Outdated Show resolved Hide resolved
@glo71317
Copy link
Contributor Author

@froschdesign I have resolved the review comments so can you please take a look on this again?

@Ocramius Ocramius self-assigned this Nov 10, 2023
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @glo71317!

@Ocramius Ocramius merged commit 2f255f1 into laminas:2.17.x Nov 10, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants