-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Support for PHP 8.0, Add Support for PHP 8.3 #74
Conversation
7dfee11
to
e320892
Compare
Once #72 is merged, this patch can be rebased and CI should go green |
@gsteel done |
e320892
to
e594cf6
Compare
This patch is going to need more work. I don't know the details yet, but it looks like a bunch of #[ReturnTypeWillChange] attribs are required, a bump to ServiceManager, and dealing with deprecations there, and also fixing unnecessary reflection api calls. |
Also, doesn't look like the mongodb extension for 8.3 is available yet |
00b65c7
to
866d053
Compare
4ead25c
to
2511842
Compare
@gsteel all issues fixed except - mongodb extension as mongodb extension php 8.3 is not available yet, Will have to wait or any otherway to do this? |
The mongodb extension can be installed via pecl: |
d2ec1b9
to
74bb732
Compare
All tests passed except one which is failing due to mongodb extension |
@gsteel Can you please have a look the PR? Any action is required from our end. |
Until MongoDB ext is released, nothing to do here, IMO. |
@glo71317 @Ocramius laminas-session/.laminas-ci/install-mongodb-extension-via-pecl.sh Lines 1 to 14 in a2af774
And this must be updated. Compare with: laminas/laminas-cache-storage-adapter-ext-mongodb#45 |
@froschdesign Thanks for suggesting! @Ocramius Now PR got green now you can proceed for merging. |
@froschdesign I have resolved the review comments so can you please take a look on this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @glo71317!
Description