Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix standardize exact matches #94

Merged
merged 2 commits into from
Nov 20, 2024
Merged

🐛 Fix standardize exact matches #94

merged 2 commits into from
Nov 20, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Nov 18, 2024

Related to @felix0097 issue

The newly added test failed before and is what he ran into in his instance. The new implementation:

  1. Explicitly calculates unmatched terms by comparing the input identifiers (mapped_df["__agg__"]) with the field_map.index.
  2. If all terms match directly, synonym mapping and other fallback logic are skipped entirely, preserving the correct results for Plasmablast and cDC.

Signed-off-by: zethson <[email protected]>
@Zethson Zethson changed the title 🐛 Fix synonyms search 🐛 Fix standardize exact matches Nov 18, 2024
@falexwolf
Copy link
Member

Great!

I'm curious: is the "search on synonyms" logic duplicated across lamindb and bionty? If so, is there still any reason to have this after integrating bionty with lamindb? (I guess this is mostly a question for @sunnyosun)

@Koncopd
Copy link
Member

Koncopd commented Nov 19, 2024

I think it doesn't matter much as i will also port the search logic from lamindb to bionty soon.

@falexwolf
Copy link
Member

I think it doesn't matter much as i will also port the search logic from lamindb to bionty soon.

That means it's in fact duplicated right now, which was evidently very error prone. Good that this gets consolidated.

@Zethson Zethson requested a review from sunnyosun November 20, 2024 13:34
Copy link
Member

@sunnyosun sunnyosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Zethson Zethson merged commit a7bd725 into main Nov 20, 2024
1 check passed
@Zethson Zethson deleted the fix/synonyms_search branch November 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants