Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ nbclassic environment support #252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Feb 11, 2023

This adds full support for nbclassic.
Also adds yet another way to infer path for nbclassic and classic notebook.

However, downside is a quick blink effect on import nbproject in a lab cell. @falexwolf , could that be a problem?

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request February 11, 2023 18:14 Inactive
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #252 (2663d64) into main (214478a) will decrease coverage by 0.61%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   89.14%   88.54%   -0.61%     
==========================================
  Files          24       24              
  Lines        1023     1039      +16     
==========================================
+ Hits          912      920       +8     
- Misses        111      119       +8     
Impacted Files Coverage Δ
nbproject/dev/_jupyter_communicate.py 38.53% <10.00%> (-1.86%) ⬇️
nbproject/dev/_classic_nb_commands.py 67.85% <66.66%> (-0.57%) ⬇️
nbproject/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant