Skip to content

Commit

Permalink
feat(python): support customize credential provider for write_dataset…
Browse files Browse the repository at this point in the history
… api in PyLance
  • Loading branch information
yanghua committed Dec 23, 2024
1 parent 805438f commit 596533b
Show file tree
Hide file tree
Showing 5 changed files with 282 additions and 3 deletions.
138 changes: 138 additions & 0 deletions python/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ tracing-subscriber = "0.3.17"
tracing = "0.1.37"
url = "2.5.0"
bytes = "1.4"
reqwest = { version = "0.12.9", features = [] }

[features]
datagen = ["lance-datagen"]
Expand Down
19 changes: 16 additions & 3 deletions python/src/dataset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ use lance_io::object_store::ObjectStoreParams;
use lance_linalg::distance::MetricType;
use lance_table::format::Fragment;
use lance_table::io::commit::CommitHandler;
use object_store::aws::AwsCredential;
use object_store::path::Path;
use object_store::CredentialProvider;
use pyo3::exceptions::{PyStopIteration, PyTypeError};
use pyo3::prelude::*;
use pyo3::types::{PyBytes, PyInt, PyList, PySet, PyString};
Expand All @@ -71,17 +73,18 @@ use pyo3::{
};
use snafu::{location, Location};

use self::cleanup::CleanupStats;
use self::commit::PyCommitLock;
use crate::error::PythonErrorExt;
use crate::file::object_store_from_uri_or_path;
use crate::fragment::FileFragment;
use crate::object_store::UrlBasedCredentialProvider;
use crate::schema::LanceSchema;
use crate::session::Session;
use crate::utils::PyLance;
use crate::RT;
use crate::{LanceReader, Scanner};

use self::cleanup::CleanupStats;
use self::commit::PyCommitLock;
use pyo3::types::PyAny;

pub mod blob;
pub mod cleanup;
Expand Down Expand Up @@ -1590,8 +1593,18 @@ pub fn get_write_params(options: &PyDict) -> PyResult<Option<WriteParams>> {
if let Some(storage_options) =
get_dict_opt::<HashMap<String, String>>(options, "storage_options")?
{
let credential_provider: Option<
Arc<dyn CredentialProvider<Credential = AwsCredential>>,
> = if let Some(url) = storage_options.get("assume_role_credential_url") {
Some(Arc::new(UrlBasedCredentialProvider::new(url.parse()?))
as Arc<dyn CredentialProvider<Credential = AwsCredential>>)
} else {
None
};

p.store_params = Some(ObjectStoreParams {
storage_options: Some(storage_options),
aws_credentials: credential_provider,
..Default::default()
});
}
Expand Down
1 change: 1 addition & 0 deletions python/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ pub(crate) mod executor;
pub(crate) mod file;
pub(crate) mod fragment;
pub(crate) mod indices;
pub(crate) mod object_store;
pub(crate) mod reader;
pub(crate) mod scanner;
pub(crate) mod schema;
Expand Down
Loading

0 comments on commit 596533b

Please sign in to comment.