Skip to content

Commit

Permalink
chore: remove legacy C plugin integration (#3243)
Browse files Browse the repository at this point in the history
The plugin hasn't built in over a year and the fact that we have git
submodules can cause expensive build times for downstream projects like
lancedb when they need to declare a git dependency on lance. If we need
it back later we can always revert the change.
  • Loading branch information
westonpace authored Dec 14, 2024
1 parent c310aee commit 6203435
Show file tree
Hide file tree
Showing 31 changed files with 0 additions and 1,989 deletions.
64 changes: 0 additions & 64 deletions .github/workflows/duckdb.yml

This file was deleted.

5 changes: 0 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,6 @@ docs/api/python
**/.ipynb_checkpoints/
docs/notebooks


integration/duckdb/*-build
integration/duckdb/lance.duckdb_extension.*.zip

notebooks/lance.duckdb_extension
notebooks/sift
notebooks/image_data/data
benchmarks/sift/sift
Expand Down
6 changes: 0 additions & 6 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,6 +0,0 @@
[submodule "integration/duckdb_lance/duckdb"]
path = integration/duckdb_lance/duckdb
url = https://github.com/duckdb/duckdb.git
[submodule "integration/duckdb_lance/duckdb-ext/duckdb"]
path = integration/duckdb_lance/duckdb-ext/duckdb
url = https://github.com/duckdb/duckdb.git
7 changes: 0 additions & 7 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,6 @@ Example Notebooks

Example notebooks are under `examples`. These are standalone notebooks you should be able to download and run.

DuckDB Extension
~~~~~~~~~~~~~~~~

In python, Lance integrates with DuckDB via Apache Arrow. Outside of python, the highly experimental duckdb extension for Lance
lives under `integration/duckdb_lance`. This uses the DuckDB `Rust extension framework <https://github.com/Mause/duckdb-extension-framework>`_.
The main code lives under `integration/duckdb_lance/src`. Follow the integration README for more details.

Benchmarks
~~~~~~~~~~

Expand Down
72 changes: 0 additions & 72 deletions integration/duckdb_lance/CMakeLists.txt

This file was deleted.

21 changes: 0 additions & 21 deletions integration/duckdb_lance/Cargo.toml

This file was deleted.

21 changes: 0 additions & 21 deletions integration/duckdb_lance/Makefile

This file was deleted.

10 changes: 0 additions & 10 deletions integration/duckdb_lance/README.md

This file was deleted.

1 change: 0 additions & 1 deletion integration/duckdb_lance/duckdb
Submodule duckdb deleted from f78273
11 changes: 0 additions & 11 deletions integration/duckdb_lance/duckdb-ext/Cargo.toml

This file was deleted.

6 changes: 0 additions & 6 deletions integration/duckdb_lance/duckdb-ext/README.md

This file was deleted.

40 changes: 0 additions & 40 deletions integration/duckdb_lance/duckdb-ext/build.rs

This file was deleted.

1 change: 0 additions & 1 deletion integration/duckdb_lance/duckdb-ext/duckdb
Submodule duckdb deleted from f78273
41 changes: 0 additions & 41 deletions integration/duckdb_lance/duckdb-ext/src/connection.rs

This file was deleted.

Loading

0 comments on commit 6203435

Please sign in to comment.