Skip to content

Commit

Permalink
fix: respect storage options on create_index (#2460)
Browse files Browse the repository at this point in the history
Currently, if `create_index` is used with non-standard storage backends,
or configuration options passed at runtime, `lance` does not respect the
storage option specified. This can be resolved by checking and passing
`storage_options` from the `create_index` methods to allow for the
`LanceDataset` to be recreated.

---------

Co-authored-by: Will Jones <[email protected]>
  • Loading branch information
joshua-auchincloss and wjones127 authored Jun 12, 2024
1 parent 848a5db commit f97a7cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/python/lance/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -1526,7 +1526,7 @@ def create_index(
kwargs["shuffle_partition_concurrency"] = shuffle_partition_concurrency

self._ds.create_index(column, index_type, name, replace, kwargs)
return LanceDataset(self.uri, index_cache_size=index_cache_size)
return self

def session(self) -> Session:
"""
Expand Down

0 comments on commit f97a7cd

Please sign in to comment.