feat: add python bindings for the v2 reader/writer #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
force-pushed
the
feat/v2-python-bindings
branch
from
137c004 to
e83702e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
- Coverage 81.04% 80.99% -0.06%
==========================================
Files 181 181
Lines 51279 51385 +106
Branches 51279 51385 +106
==========================================
+ Hits 41560 41620 +60
- Misses 7282 7344 +62
+ Partials 2437 2421 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
approved these changes
Apr 9, 2024
eddyxu
reviewed
Apr 9, 2024
python/python/lance/file.py
Outdated
| @@ -0,0 +1,188 @@ | |||
| # Copyright (c) 2023. Lance Developers | |||
eddyxu
reviewed
Apr 9, 2024
|
|
||
| class LanceFileReader: | ||
| """ | ||
| A file reader for reading Lance files |
There was a problem hiding this comment.
Is this interface mostly internal utility? The public main interface is still pyarrow.Dataset?
There was a problem hiding this comment.
Yes. This is mainly for benchmarking / advanced use cases.
eddyxu
reviewed
Apr 9, 2024
westonpace
force-pushed
the
feat/v2-python-bindings
branch
from
b27f6af to
0ef20f1
Compare
chebbyChefNEQ
pushed a commit
that referenced
this pull request
Apr 10, 2024
Prerequisites: - [x] #1965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites: