ci: auto release java #2827
ci: auto release java #2827
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
| run: | | ||
| cargo install cargo-workspaces --version 0.2.44 | ||
| cargo ws version --no-git-commit -y --exact --force 'lance*' ${{ inputs.part }} | ||
| - name: Bump java version |
There was a problem hiding this comment.
in my previous experience, we always only auto-bump patch version. all major/minor should be manual commit. but it is up to the lance community :-P
There was a problem hiding this comment.
Yeah, lance community also only auto bump patch version, major/minor needs to be manual commit.
Lancedb release pipeline opens the door for auto bump minor version but is also not recommended.
There was a problem hiding this comment.
ok i might've misunderstood. but looksl ike the code below handles major/minor/patch bump?
There was a problem hiding this comment.
We have the capability to bump other versions, but we generally only automatically increment minor version.
| @@ -93,4 +93,4 @@ jobs: | |||
| -Djdk.reflect.useDirectMethodHandle=false \ | |||
| -Dio.netty.tryReflectionSetAccessible=true" | |||
| fi | |||
| mvn clean test | |||
| mvn clean install | |||
| - name: Publish with Java 8 | ||
| if: github.event_name == 'release' |
There was a problem hiding this comment.
i am a bit confused here. dont you need to invoke bump version first before running Publish with Java 8 ?
There was a problem hiding this comment.
The release pipeline is
- create a github tag with version bumped
- create a github release with the created tag
- a github stable release automatically triggers the java/python publish process
There was a problem hiding this comment.
ah i see. i've also see you modified the release_process.md. nice. thanks!
| # Use released instead of published, since we don't publish preview/beta | ||
| # versions |
There was a problem hiding this comment.
Do you want to start publishing them later? Feel like it could be useful since we distribute the binaries for Java, right? The only reason we skip Rust is because it's a source-only release, so there's no benefit of publishing over just letting people reference the git repo directly.
Automatically bump java patch version during stable release
Automatically trigger java publish when detected a stable release