Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add replace_schema_metadata and replace_field_metadata #3263

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat: add replace_schema_metadata and replace_field_metadata #3263

merged 2 commits into from
Dec 17, 2024

Conversation

westonpace
Copy link
Contributor

No description provided.

@github-actions github-actions bot added enhancement New feature or request python labels Dec 17, 2024
@westonpace
Copy link
Contributor Author

I've chosen to modify the existing UpdateConfig instead of adding a new operation but we could also add a new operation if we think that's better.

@westonpace westonpace requested a review from wjones127 December 17, 2024 14:14
@wjones127
Copy link
Contributor

I've chosen to modify the existing UpdateConfig instead of adding a new operation but we could also add a new operation if we think that's better.

FWIW, I plan on completely refactoring transactions work at some point in the near future. #3204

wjones127
wjones127 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@westonpace
Copy link
Contributor Author

FWIW, I plan on completely refactoring transactions work at some point in the near future. #3204

I'll take a look (and try and sneak this in :) )

@westonpace westonpace merged commit b1ab748 into lancedb:main Dec 17, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@westonpace @wjones127