Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): support add columns via sql expressions #3287

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yanghua
Copy link
Contributor

@yanghua yanghua commented Dec 24, 2024

No description provided.

@github-actions github-actions bot added the java label Dec 24, 2024
Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@yanghua yanghua changed the title Support add columns via sql expressions feat(java): support add columns via sql expressions Dec 24, 2024
@github-actions github-actions bot added the enhancement New feature or request label Dec 24, 2024
@yanghua
Copy link
Contributor Author

yanghua commented Dec 24, 2024

@wjones127 Considering there are many ways to add columns, to reduce the complexity of the rust binding methods, I will define one addColumns and its multiple override methods and multiple native methods for mapping. And one override method one PR, to reduce the cost for code review.

WDYT?

@wjones127
Copy link
Contributor

Considering there are many ways to add columns, to reduce the complexity of the rust binding methods, I will define one addColumns and its multiple override methods and multiple native methods for mapping. And one override method one PR, to reduce the cost for code review.

WDYT?

That seems fine.

@yanghua
Copy link
Contributor Author

yanghua commented Dec 25, 2024

@wjones127 Have addressed your concerns, please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants