Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: is not false crash #3298

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

chenkovsky
Copy link
Contributor

No description provided.

@github-actions github-actions bot added bug Something isn't working python labels Dec 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (c6fcb31) to head (f39382d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-datafusion/src/planner.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
- Coverage   79.00%   78.97%   -0.04%     
==========================================
  Files         246      246              
  Lines       87589    87589              
  Branches    87589    87589              
==========================================
- Hits        69203    69172      -31     
- Misses      15522    15552      +30     
- Partials     2864     2865       +1     
Flag Coverage Δ
unittests 78.97% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddyxu eddyxu merged commit 7363a53 into lancedb:main Dec 31, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants