feat(java): support overwrite for spark connector #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
eddyxu
reviewed
Dec 31, 2024
| @@ -54,7 +54,11 @@ public static LanceFragmentScanner create( | |||
| LanceConfig config = inputPartition.getConfig(); | |||
| ReadOptions options = SparkOptions.genReadOptionFromConfig(config); | |||
| dataset = Dataset.open(allocator, config.getDatasetUri(), options); | |||
| fragment = dataset.getFragments().get(fragmentId); | |||
| fragment = | |||
| dataset.getFragments().stream() | |||
There was a problem hiding this comment.
This is a O(n) operation? is it sensitive to the performance here?
There was a problem hiding this comment.
If we want to use an O(1) operation to get the fragment, it has to build the dataset.getFragments() as a hash table and store it in the LanceInputPartition.
The LanceInputPartition will be serialized in spark and it will cause a lot of memory for a big lance dataset. So I think maybe the O(n) filter is a suitable way here.
eddyxu
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support overwrite for lance spark connector