feat(java): support take api for java module #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanghua
force-pushed
the
take-api-for-java
branch
from
49d467f to
e202fdc
Compare
yanghua
commented
Dec 30, 2024
| * @param columns the columns to take | ||
| * @return an ArrowReader | ||
| */ | ||
| public ArrowReader take(List<Integer> indices, List<String> columns) throws IOException { |
There was a problem hiding this comment.
There will be another overload method for indices and SQL expressions.
eddyxu
reviewed
Dec 31, 2024
eddyxu
reviewed
Dec 31, 2024
yanghua
force-pushed
the
take-api-for-java
branch
from
4d6a338 to
4d3ae30
Compare
eddyxu
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.