Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(py): support count rows with filter in a fragment #3318

Merged
merged 9 commits into from
Dec 31, 2024

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Dec 31, 2024

No description provided.

@eddyxu eddyxu requested review from wjones127, chebbyChefNEQ and BubbleCal and removed request for wjones127 December 31, 2024 06:50
@github-actions github-actions bot added enhancement New feature or request python labels Dec 31, 2024
@github-actions github-actions bot added the java label Dec 31, 2024
@eddyxu eddyxu requested a review from westonpace December 31, 2024 07:53
@eddyxu
Copy link
Contributor Author

eddyxu commented Dec 31, 2024

@westonpace need some help to take a look of this overflow issue.


thread 'dataset::scanner::test::test_plans::data_storage_version_1_LanceFileVersion__Legacy::stable_row_id_1_false' has overflowed its stack

@westonpace
Copy link
Contributor

@westonpace need some help to take a look of this overflow issue.

Probably a large futures need boxed thing. I'll take a look.

@westonpace
Copy link
Contributor

@eddyxu fixed stack overflow. Remaining test failures look related to count_rows change?

@eddyxu
Copy link
Contributor Author

eddyxu commented Dec 31, 2024

Thanks @westonpace . Fixed the rest of test

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.77049% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (7363a53) to head (5984dcb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 77.50% 1 Missing and 8 partials ⚠️
rust/lance/src/dataset/fragment.rs 75.00% 0 Missing and 4 partials ⚠️
rust/lance/src/dataset/take.rs 0.00% 0 Missing and 2 partials ⚠️
java/core/lance-jni/src/fragment.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3318      +/-   ##
==========================================
- Coverage   79.03%   79.00%   -0.04%     
==========================================
  Files         246      246              
  Lines       87628    87675      +47     
  Branches    87628    87675      +47     
==========================================
+ Hits        69256    69266      +10     
- Misses      15505    15530      +25     
- Partials     2867     2879      +12     
Flag Coverage Δ
unittests 79.00% <73.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddyxu eddyxu merged commit 898396d into main Dec 31, 2024
29 checks passed
@eddyxu eddyxu deleted the lei/fragment_count_rows branch December 31, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants