-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(py): support count rows with filter in a fragment #3318
Conversation
@westonpace need some help to take a look of this overflow issue.
|
Probably a large futures need boxed thing. I'll take a look. |
@eddyxu fixed stack overflow. Remaining test failures look related to count_rows change? |
Thanks @westonpace . Fixed the rest of test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
==========================================
- Coverage 79.03% 79.00% -0.04%
==========================================
Files 246 246
Lines 87628 87675 +47
Branches 87628 87675 +47
==========================================
+ Hits 69256 69266 +10
- Misses 15505 15530 +25
- Partials 2867 2879 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.