Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lance ray sink crash when fields contain none #3322

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix: lance ray sink crash when fields contain none #3322

merged 1 commit into from
Jan 1, 2025

Conversation

Jay-ju
Copy link
Contributor

@Jay-ju Jay-ju commented Jan 1, 2025 •
edited
Loading

fix #3308

@github-actions github-actions bot added bug Something isn't working python labels Jan 1, 2025
@eddyxu eddyxu merged commit 783bc12 into lancedb:main Jan 1, 2025
14 of 15 checks passed
andrijazz
andrijazz reviewed Jan 2, 2025
View reviewed changes
python/python/lance/ray/sink.py
new_field = pa.field(field, col.type)
if (
pa.types.is_null(col.type)
and schema.field_by_name(field).type == pa.string()
Copy link

@andrijazz andrijazz Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jay-ju @eddyxu Please correct me if I am wrong but this looks like None support is added only for the pa.string data type. I would assume that we want None to apply to any nullable field regardless of data type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrijazz andrijazz andrijazz left review comments

@eddyxu eddyxu eddyxu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LanceDatasink for integration with ray doesn't support None
3 participants
@Jay-ju @eddyxu @andrijazz