Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache miniblock metadata #3323

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

westonpace
Copy link
Contributor

The miniblock chunk data was always intended to be cached. This is essential for good random access performance. This PR adds that caching.

@westonpace
Copy link
Contributor Author

westonpace commented Jan 1, 2025

Leaving in draft until #3321 is merged

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 73.98374% with 32 lines in your changes missing coverage. Please review.

Project coverage is 78.90%. Comparing base (c0c1b53) to head (02b6f82).

Files with missing lines Patch % Lines
rust/lance-datagen/src/generator.rs 0.00% 22 Missing ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 89.88% 5 Missing and 4 partials ⚠️
rust/lance-core/src/utils/path.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3323      +/-   ##
==========================================
- Coverage   78.92%   78.90%   -0.02%     
==========================================
  Files         246      246              
  Lines       87805    87903      +98     
  Branches    87805    87903      +98     
==========================================
+ Hits        69298    69363      +65     
- Misses      15629    15660      +31     
- Partials     2878     2880       +2     
Flag Coverage Δ
unittests 78.90% <73.98%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace force-pushed the feat/cache_miniblock_metadata branch from ac02d35 to 02b6f82 Compare January 2, 2025 18:30
@westonpace westonpace marked this pull request as ready for review January 2, 2025 18:30
@westonpace westonpace merged commit 8fe7147 into lancedb:main Jan 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants