Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade datafusion to 44.0 #3341

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

westonpace
Copy link
Contributor

I wanted to upgrade to 44 to check and see if the string sorting bug was fixed. It wasn't. However, it might still be useful to commit this since we'll need to upgrade at some point.

@github-actions github-actions bot added enhancement New feature or request python labels Jan 6, 2025
@westonpace
Copy link
Contributor Author

Hmm, seems this introduces some legitimate test failures. I'll need to investigate further.

@westonpace westonpace force-pushed the feat/upgrade-df-to-44 branch from 1700e07 to 62b8eeb Compare January 13, 2025 14:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.50%. Comparing base (2142594) to head (789d482).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-datafusion/src/exec.rs 56.25% 7 Missing ⚠️
rust/lance/src/dataset/scanner.rs 80.00% 2 Missing and 4 partials ⚠️
rust/lance-datafusion/src/substrait.rs 44.44% 4 Missing and 1 partial ⚠️
rust/lance/src/datafusion/dataframe.rs 0.00% 5 Missing ⚠️
rust/lance/src/dataset/write/merge_insert.rs 93.47% 0 Missing and 3 partials ⚠️
rust/lance-datafusion/src/planner.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3341      +/-   ##
==========================================
+ Coverage   78.44%   78.50%   +0.06%     
==========================================
  Files         250      250              
  Lines       90141    90193      +52     
  Branches    90141    90193      +52     
==========================================
+ Hits        70710    70806      +96     
+ Misses      16509    16479      -30     
+ Partials     2922     2908      -14     
Flag Coverage Δ
unittests 78.50% <80.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit cf49205 into lancedb:main Jan 13, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants