-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add drop_index #3382
feat: add drop_index #3382
Conversation
python/python/lance/dataset.py
Outdated
@@ -2222,6 +2222,16 @@ def create_index( | |||
) | |||
return self | |||
|
|||
def drop_index(self, column: str, name: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is column required? or solely name is enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I didn't realize index names were unique but after some testing it appears this is the case. So the name should be all we need 🎉
I'll fix the PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3382 +/- ##
==========================================
- Coverage 78.47% 78.46% -0.01%
==========================================
Files 250 250
Lines 90243 90433 +190
Branches 90243 90433 +190
==========================================
+ Hits 70817 70960 +143
- Misses 16521 16557 +36
- Partials 2905 2916 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Helpful for when an index is created by mistake or no longer needed.