Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a blocking take to the 2.1 file reader (useful for takes against fast storage) #3389

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

westonpace
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Jan 16, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.83624% with 55 lines in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (9f7e012) to head (924dddc).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-encoding/src/decoder.rs 77.93% 30 Missing and 2 partials ⚠️
rust/lance-file/src/v2/reader.rs 83.33% 18 Missing and 4 partials ⚠️
...ust/lance-encoding/src/encodings/logical/struct.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3389      +/-   ##
==========================================
+ Coverage   78.51%   78.68%   +0.17%     
==========================================
  Files         250      250              
  Lines       90379    90759     +380     
  Branches    90379    90759     +380     
==========================================
+ Hits        70957    71413     +456     
+ Misses      16513    16421      -92     
- Partials     2909     2925      +16     
Flag Coverage Δ
unittests 78.68% <80.83%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants