Merge pull request #2 from landerlini/landerlini_do_not_hide_exceptio…

…ns_in_context

Added reproducer for issue landerlini/hopaas#26 and fixed it

hopaas_client/Study.py

@@ -139,8 +139,11 @@ def trial(self):
 
         try:
             yield trial
-        except (Exception, KeyboardInterrupt):
+        except KeyboardInterrupt:
             trial.loss = None
+        except Exception as e:
+            trial.loss = None
+            raise e
         finally:
             if trial.loss is not None:
                 if not trial.should_prune:

tests/test_Errors.py

@@ -0,0 +1,27 @@
+import random
+import pytest
+
+RANDOM_CODE = random.randint(0, 10000)
+
+
+@pytest.fixture
+def study():
+    from hopaas_client import Study
+    study = Study('TEST::Study::study', dict(some_value=RANDOM_CODE))
+    return study
+
+
+################################################################################
+
+
+def test_trial_context_error(study):
+    try:
+        with study.trial() as trial:
+            print(1 // 0)
+    except ZeroDivisionError:
+        return True
+    else:
+        raise AssertionError("A ZeroDivisionError was masked")
+
+
+