Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct planet size calculation when creating a new planet #391

Closed
lanedirt opened this issue Oct 14, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@lanedirt
Copy link
Owner

Currently when a new planet is created a random planet size is chosen based on this logic in PlanetServiceFactory::createPlanet():

        $planet->field_max = rand(140, 250);

So currently the planet size is fully random and does not take into account any other information.

The official game however implements certain rules for a small or big a planet can become based on the position of the planet. Up-to-date information can be found here: https://ogame.fandom.com/wiki/Planet_Size.

Todo:

  • Change the planet size calculation logic to conform to how the official game works.
@lanedirt lanedirt added the enhancement New feature or request label Oct 14, 2024
yazilimmz added a commit to yazilimmz/OGameX that referenced this issue Dec 23, 2024
lanedirt added a commit that referenced this issue Dec 24, 2024
@lanedirt
Copy link
Owner Author

Fixed by #507.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant