planet size calculation #391 fixes #507
Conversation
There was a problem hiding this comment.
Hi @yazilimmz,
Thanks for your contribution and for looking into implementing the planet size calculations!
Overall the changes to the field calculation looks good to me. I reviewed the changes and did add two comments, see below. Could you take a look at these?
If you have any questions feel free to let me know. Thanks again for your time in helping out, much appreciated! 🚀 😃
|
Hello, Using this link: I noticed that it corresponds to the base production, so I updated it based on that. |
app/Services/PlanetService.php
Outdated
| @@ -1462,6 +1520,7 @@ public function getPlanetBasicIncome(): Resources | |||
| */ | |||
| private function updateResourceProductionStatsInner(Resources $production_total, int|float $energy_production_total, int|float $energy_consumption_total, bool $save_planet = true): void | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
It looks like nothing changed in this method updateResourceProductionStatsInner() except adding and removing a newline, can you revert the change on line 1523 and line 1482?
There was a problem hiding this comment.
It looks like nothing changed in this method
updateResourceProductionStatsInner()except adding and removing a newline, can you revert the change on line 1523 and line 1482?
I have updated the code again for your reference. Since the production calculations are added to the base production, you can see it in PlanetService::getPlanetBasicIncome().
|
Hi @yazilimmz, Thanks for the adjustments, functionally it looks good to me now. I noticed that some tests were failing, but as I was typing this I saw your new commit come in and now it looks like its working properly, nice 😄! Will merge this PR now. Welcome as an official contributor to the OGameX project 🚀 ! For the other changes you mentioned earlier regarding energy and deuterium output an issue already exists, see: If you have the time to look at this it would be greatly appreciated :-) |
I made changes based on this page. Adjustments were made according to the first planet.