terraformer planet field bonus logic

[jackbayliss]

This should handle #392

Also adds a variety of tests - feel free to let me know any adjustments.

[lanedirt]

Hi @jackbayliss,

Changes look good to me! I just have a few small whiteline nitpicks to make it a little bit cleaner and conform to the rest of the codebase. Could you take a look at these?

Other than these minor style tweaks, functionality looks to be working great. Thanks for your work on this! 🚀

[jackbayliss]

@lanedirt Should hopefully now be sorted, did spot a previous test I did where I missed a whitespace after the closing brace, so sorted that too.

[lanedirt]

Hi @jackbayliss,

Thanks for the refactor! In the latest diff, I noticed a duplicate blank line that still remains. Could you take a look at this?

By the way, I'll try to see if I can incorporate these style checks into the PSR/PhpStan code analysis so that the build process can automatically detect them. That should make things easier going forward.

Thanks again for your work and time 😄 !

[jackbayliss]

@lanedirt Good catch, must of missed it- I've now adjusted it.

It would be ideal if we could add this into the code analysis as I guess everyone has their own style 😃

[lanedirt]

LGTM!

[jackbayliss]

Not sure why the test failed! Looks to be a bit flaky, but I believe this is already in another issue?

[lanedirt]

Not sure why the test failed! Looks to be a bit flaky, but I believe this is already in another issue?

Yes it looks like it's the same issue as reported in #401. Have to look into fixing that one soon. 🐛 Re-running tests now.

Edit: tests succeeded. Merging now 🚀 !