New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] Windows entrypoint adjustments #500

Merged

lanedirt merged 1 commit into lanedirt:main from jackbayliss:minor-adjustments

Dec 17, 2024

Contributor

jackbayliss commented Dec 17, 2024 •

edited

Loading

This closes #501 :

added a shebang to ensure the container knows what interpreter to use
uses [[ instead of [, which is more robust I believe
directly invoke exec php-fpm, rather than passing it a string
adjusts spacing

Also wrapped some ports I found in quotes

Not sure which fixed the entrypoint issue, but seems to work locally now

This works on Windows, but please check on mac etc, but I believe it should be fine :)


          mior adjustments

e87b228

jackbayliss marked this pull request as ready for review

December 17, 2024 22:47

jackbayliss changed the title ~~Windows entrypoitnt adjustments~~ [9.0] Windows entrypoint adjustments

Owner

lanedirt commented Dec 17, 2024

Just tested it on Mac, looks to be working fine there. Linux also works as the tests show. Thanks, merging!

lanedirt merged commit 9bc0299 into lanedirt:main

5 checks passed

lanedirt added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug