Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ChatVertexAI rich docstring #287

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

baskaryan
Copy link
Contributor

@baskaryan baskaryan commented Jun 7, 2024

part of #22296

@baskaryan baskaryan requested a review from lkuligin June 7, 2024 16:03
https://cloud.google.com/docs/authentication/application-default-credentials#GAC
and https://googleapis.dev/python/google-auth/latest/reference/google.auth.html#module-google.auth.

Key init args — completion params:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: maybe we can use a hint that these args might be overriden by the invoke kwargs?

baskaryan added a commit to langchain-ai/langchain that referenced this pull request Jun 10, 2024
@baskaryan baskaryan merged commit dd223b2 into main Jun 11, 2024
15 checks passed
@baskaryan baskaryan deleted the bagatur/vertexai_docstring branch June 11, 2024 20:12
hinthornw pushed a commit to langchain-ai/langchain that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants