Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing aadd_documents to avoid Recursion Error #29

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Removing aadd_documents to avoid Recursion Error #29

merged 1 commit into from
Dec 19, 2024

Conversation

keenborder786
Copy link
Contributor

A RecursionError was being thrown because aadd_document was calling aadd_texts without any changes in its implementation from add_documents. To resolve this, aadd_document was removed, preventing the RecursionError, and the base method from VectorStore is now used instead.

Takes care of the following issue: langchain-ai/langchain#28727

@keenborder786 keenborder786 mentioned this pull request Dec 15, 2024
Open
5 tasks
@keenborder786
Copy link
Contributor Author

@efriis

@zc277584121 zc277584121 self-requested a review December 19, 2024 02:33
@zc277584121 zc277584121 merged commit b925dac into langchain-ai:main Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zc277584121 zc277584121 Awaiting requested review from zc277584121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keenborder786 @zc277584121