Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add kwargs support to VectorStore #25934

Merged
merged 14 commits into from
Dec 16, 2024

Conversation

hwchase17
Copy link
Contributor

@hwchase17 hwchase17 commented Sep 2, 2024

has been missing the passthrough until now

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 6:55pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module labels Sep 2, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 2, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 2, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 2, 2024
@terwayp
Copy link

terwayp commented Sep 17, 2024

Hello,

Do you have an estimate when this change can be merged into main?

Prerit

@NaniNorris
Copy link

When will this changes merge to main ?

@efriis efriis self-assigned this Dec 13, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 16, 2024
@efriis efriis enabled auto-merge (squash) December 16, 2024 06:38
@efriis efriis disabled auto-merge December 16, 2024 18:55
@efriis efriis changed the title Harrison/support kwargs vectorstore core: add kwargs support to VectorStore Dec 16, 2024
@efriis efriis enabled auto-merge (squash) December 16, 2024 18:56
@efriis efriis merged commit de7996c into master Dec 16, 2024
82 checks passed
@efriis efriis deleted the harrison/support-kwargs-vectorstore branch December 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants