community: verbose CSVLoader exception raise #27151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
efriis
reviewed
Dec 13, 2024
There was a problem hiding this comment.
I like this change in principle, but unfortunately it might have to wait for a minor bump because it will break people's code who are catching RuntimeError currently, and this change would cause ValueError to be thrown. Will discuss with the team and get back to you with either a PR merge or close.
If we do close, will add it to the list to consider for 0.4 (or more likely 1.0 further in the future)
|
Thank you for this! Closing but I've documented this PR in an (internal) list of desired breaking changes and can re-open in next version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix CSVLoader does not raise ValueError for missing metadata columns + tests
Issue: #26434
Twitter handle:
@RaphaelGozlan1