-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Remove all other keys in ChatLiteLLM and add api_key #28097
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey there! is this a recent change in litellm that merits this change / is it possible this will break something for current users of this + an old version of lite llm?
I am not sure, in the current litellm documentation it states that you can provide different provider keys by (https://docs.litellm.ai/docs/set_keys#litellm-variables):
Even from the initial version of litellm (back in Nov 2023), they are called But Plus I have not found where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenzimin from what I can tell, you're correct that the named API keys are not used and it is defensible to delete them.
I think it's preferable to just fix them in this case instead of deleting the fields, in case users are setting them somewhere.
I've updated the PR to support the api_key
field in addition to the named keys. Let me know if you see any issues with this.
Thanks!
Thank you for contributing to LangChain!
PR title: "community: Remove all other keys in ChatLiteLLM and add api_key"
PR message: Currently, no api_key are passed to LiteLLM, and LiteLLM only takes on api_key parameter. Therefore I removed all current
*_api_key
attributes (They are not used), and addedapi_key
that is passed to ChatLiteLLM.