-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Corrected aload func to be asynchronous from webBaseLoader #28337
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I understand you might be busy, but I would greatly appreciate it if you could provide comments on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spending the time on this! I suggest a way to partially handle the problem without making a breaking change to this code since it's used by a lot of people as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry forgot to actually submit the comments
libs/community/langchain_community/document_loaders/web_base.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/web_base.py
Outdated
Show resolved
Hide resolved
I will make the revisions based on the comments. Thank you! |
✅ [What I've done]
⏳ [What remains to do]
Could you please provide comments on the revised code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yeounhak!
I've made some updates:
- Keep
.scrape_all
as this is in the public API (your updating the tests in other integrations previews what developers would have to do if we deleted it). - Keep behavior of synchronous loading unchanged.
- Update docs.
So in effect we are
- Implementing
.ascrape_all
(includes a slight refactor) - Implementing
.alazy_load
- Deprecating
aload
.
Description: The aload function, contrary to its name, is not an asynchronous function, so it cannot work concurrently with other asynchronous functions.
Issue: 🐛Bug: The aload function, contrary to its name, is not an asynchronous function, so it cannot work concurrently with other asynchronous functions. #28336
**Test: **: Done
**Docs: ** here
**Lint: ** All checks passed
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.