Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve docstring parsing logic for Google style compliance #28729

Closed
wants to merge 8 commits into from

Conversation

isatyamks
Copy link
Contributor

Thank you for contributing to LangChain!

  • PR title: "package: description"
    • Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"

Description:
Improved the _parse_google_docstring function in langchain/core to support parsing multi-paragraph descriptions before the Args: section while maintaining compliance with Google-style docstring guidelines. This change ensures better handling of docstrings with detailed function descriptions.

Issue:
Fixes #28628

Dependencies:
None.

Twitter handle:
@isatyamks

Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2024 6:24pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. langchain Related to the langchain package labels Dec 15, 2024
@isatyamks isatyamks closed this Dec 15, 2024
@isatyamks isatyamks deleted the 28628 branch December 15, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the langchain package size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

core: make docstring parsing more robust
1 participant