Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI Generative AI new model and structured output support #28754

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

raveharpaz
Copy link
Contributor

  • PR title:
    community: Add new model and structured output support

  • PR message:

    • Description: add support for meta llama 3.2 image handling, and JSON mode for structured output
    • Issue: NA
    • Dependencies: NA
    • Twitter handle: NA
  • Add tests and docs:

    1. we have updated our unit tests,
    2. no changes required for documentation.
  • Lint and test:
    make format, make lint and make test we run successfully

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 17, 2024
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:55pm

@dosubot dosubot bot added the community Related to langchain-community label Dec 17, 2024
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raveharpaz do you want to add any tests? Seems scary to update core functionality with no tests.


Separately, would you be interested in publishing an Oracle OSS integration package (e.g., langchain-oracle or langchain-oci)? We've published a walkthrough on this process here:

https://python.langchain.com/docs/contributing/how_to/integrations/

We are encouraging contributors of LangChain integrations to go this route. This way we don't have to be in the loop for reviews, you're able to properly integration test the model, and you have control over versioning.

Docs would continue to be maintained in the langchain repo.

Let me know what you think!

@raveharpaz
Copy link
Contributor Author

Hi @ccurme , thanks for the feedback

  1. new features have been thoroughly tested with our services/models. these tests cannot be shared due to confidential connection details, and the existing unit tests (based on mocked io) cover the essentials.
  2. Yes, the package version is in the works and should be available soon

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 18, 2024
@ccurme ccurme merged commit 986b752 into langchain-ai:master Dec 18, 2024
21 checks passed
@AndOliver46
Copy link

Hi @raveharpaz, thanks for adding image support for meta 3.2.

By the PR title, it seems that MetaProvider is now supporeting json_mode for structured_output, but isnt working for me...

Getting this error:
Error: TypeError('Unrecognized keyword arguments: response_format')."

With this call:
llm.with_structured_output(None, method="json_mode", include_raw=True).invoke(mensagens)

Do you have any idea? Or maybe works only with Cohere?

@raveharpaz
Copy link
Contributor Author

@AndOliver46 , thanks for the msg. You are correct, it only works for Cohere at the moment. We'll be adding support for llama some time soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants