Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve clean outdated messages periodical task #12090

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Dec 25, 2024

Summary

  • delete outdated messages from oldest ones instead of from the latest
  • fix to continue deleting messages with invalid app id
  • fix typo in logging of Cleaned unused dataset to Cleaned outdated messages in clean_message periodical task
  • allow to config batch size for deleting messages

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 25, 2024
@bowenliang123
Copy link
Contributor Author

cc @JohnJyong @laipz8200

@bowenliang123 bowenliang123 force-pushed the improve-clean-messages branch 3 times, most recently from 80a94dd to 61f47c1 Compare December 25, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants