Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve delimiter #8552

Merged
merged 4 commits into from
Sep 19, 2024
Merged

chore: improve delimiter #8552

merged 4 commits into from
Sep 19, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Sep 19, 2024

Description

  1. Add delimiter tooltip and placeholder.
  2. Fix delimiter not escape and unescape right.
  3. Change default max chunk size change.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@iamjoel iamjoel marked this pull request as ready for review September 19, 2024 09:26
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🐞 bug Something isn't working 💪 enhancement New feature or request labels Sep 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2024
@iamjoel iamjoel merged commit 7411bcf into main Sep 19, 2024
6 checks passed
@iamjoel iamjoel deleted the chore/enchance-delimiter branch September 19, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants