Add option to archive the workdir #980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhall0
commented
Dec 16, 2024
| @@ -312,6 +314,51 @@ def is_parent(parent, path): | |||
| if os.path.commonpath([os.path.realpath('/var/tmp'), workdir]) == os.path.realpath('/var/tmp'): | |||
| error_exit("Workflow working directory cannot be in \"/var/tmp\"") | |||
|
|
|||
| # TODO: this should be in a function somewhere | |||
There was a problem hiding this comment.
I tried to find some kind of python package that would do this logic, but didn't come up with anything.
I'm not sure the best place to put this function. It should likely also have some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to archive the
workdirwhen usingbeeflow submitby adding the--archive-workdirflag. Checks theworkdirisn't too large: too large file size (>1000 MB), contains too many files (>10,000), contains too many directories (>1000). If it is, prompts user to verify.Could potentially add a config option for this to always attempt to archive the
workdir. Currently that isn't implemented.