Add optional emission opacity array for eventual coronal emissivity #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanWollaeger
changed the title
|
Going to hopefully get this ready for review soon. (Merely switched to git's draft decorator rather than prefixing the title for this PR, so no real changes just now.) |
+ Add in_doemiss input to switch to using separate emissivity data. + Prevent in_doemiss=true when tabular opacity data is not used. + Add gas_em_cap and grd_em_cap array (de)allocations. + Add MPI gatherv for gas_em_cap and grd_em_cap. + Reset gas_em_cap in GAS/gas_update. + Throw stop assertion (for now) for emissivity interpolation.
RyanWollaeger
force-pushed
the
emiss_arr
branch
from
3d2c823 to
762f030
Compare
+ Format similar to tabular absorption opacity (but no scattering). + Add tb_nelem_em: size(subset of elements with emission opacity). + Add tb_em_raw: array to parse subset of emission opacity tables. + Add tb_em_cap: coarsened multgroup emission opacity array. + Add tb_em_ielem: subset of parsed elements with emission tables. + Add lemiss logical argument to read_tbxs and coarsen_tbxs. + Parse emission opacity table optionally (lemiss). + Toggle emissivity contributions as done for absorption opacity. + Add optional (de)allocation for new tbxsmod arrays. + Assume single density value for emission opacity (for now). + Assume electron temperatures to be the same as for absorption. Note: TODOs have been added. For example, Planck function needs to to be evaluated for final emission opacity evaluation (tb_em_cap).
+ Change emission element subset to tabular element mask, per rho. + Require emission table temperatures to equal those of the equivalent absorption table.
+ Add emission density and element maps to absorption indices. + Add element-density mask to avoid parsing missing emission files. + Make emission routines loop over density index. + Fix emission opacity file name character length. + Make both tb_raw and tb_em_raw double-precision. + Add temp_em to read_tbxs stack, to verify emission temperatures. + Fix sum increment of tb_em_cap in wavelength coarsening. + Add 1 cell problem input with in_doemiss=t to Input directory. + Add TODO for MPI broadcasting tabular emission data. Note: tabular_opacity.f was updated in this commit to toggle between emission and absorption opacity when constructing per-cell emission opacity, based on data availability, but it is incomplete and incorrect as of this changeset.
|
The emission parser is still being tested on a one cell problem. It is working with a preliminary emission file, but at the moment the per-cell data is not getting constructed properly. |
+ Comment out per-(bb,bf,ff) emissivity. + Attempt coarsening test of total emission opacity. + Fix density array emissivity sub-index access in coarsening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Changes
Merge Requirements