Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation to formatting and extend development docs #49

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Aug 28, 2024

PR Summary

It looks like we don't have the formatting automation we do in singularity-eos and spiner. I port it over here and also port over the relevant parts of the development guidelines from singularity-eos.

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur added documentation Improvements or additions to documentation Build Relevant for the build system labels Aug 28, 2024
@Yurlungur Yurlungur self-assigned this Aug 28, 2024
@dholladay00
Copy link
Collaborator

@Yurlungur I know that development doesn't stop but I really don't have the ability to review this stuff (anything xcap related in general really (unless I get approval from EAP)) until the new FY.

@Yurlungur Yurlungur requested review from mauneyc-LANL and removed request for dholladay00 August 28, 2024 22:46
@Yurlungur
Copy link
Collaborator Author

Understood @dholladay00 you're welcome to look but not obligated.

@Yurlungur Yurlungur requested a review from chadmeyer August 28, 2024 22:47
.clang-format Show resolved Hide resolved
cmake/Format.cmake Show resolved Hide resolved
@Yurlungur Yurlungur merged commit c7aa009 into main Aug 28, 2024
3 checks passed
@Yurlungur Yurlungur deleted the jmm/formatting-automation branch August 28, 2024 23:06
@Yurlungur Yurlungur restored the jmm/formatting-automation branch August 28, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Relevant for the build system documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants