Improve docs for linop.xray subpackage
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Cool plots!
Gut reaction: I object to the labels "y (axis 0)" and "x (axis 1)" on the SCICO plot. The code is written so that axis 0 goes with x and axis 1 axis with y. The downside of that is that it means rows <-> x and columns <-> y.
We could add the motivation for why SCICO works this way. The idea is to think about rotation (by theta) followed by projection (onto the x-axis). Probably I could improve the Parallel2dProjector docs to make this more clear (by avoiding talking about rows and columns).
|
Comments addressed. |
Michael-T-McCann
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve docs for
linop.xraysubpackage. See also lanl/scico-data#49.The effects of the changes in the built docs may be viewed here. These docs are likely to be moved or edited as part of the completion of #529.