Skip to content

Commit

Permalink
relax tolerance for chekc
Browse files Browse the repository at this point in the history
  • Loading branch information
jonahm-LANL committed Jan 3, 2025
1 parent ceec265 commit 8424efc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion singularity-eos/eos/eos_base.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,6 @@ class EosBase {
rhoguess = 0.5 * (rhomin + rhomax);
}
}
// JMM: Demand as much tolerance as we can, but don't reset rho below.
auto status = findRoot(PofRT, press, rhoguess, rhomin, rhomax, robust::EPS(),
robust::EPS(), rho);
// JMM: This needs to not fail and instead return something sane.
Expand Down
2 changes: 1 addition & 1 deletion test/eos_unit_test_helpers.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ CheckRhoSieFromPT(EOS eos, Real rho, Real T,
std::min(std::abs(singularity::robust::ratio(residual, P)), std::abs(residual));
bool results_good = (isClose(rho, rtest, 1e-8) && isClose(sie, etest, 1e-8))
// This is as good as it will get sometimes.
|| (std::abs(frac_residual) <= 10 * singularity::robust::EPS());
|| (std::abs(frac_residual) <= 1e-8);
if (!results_good) {
printf("RhoSie of PT failure!\n"
"\trho_true = %.14e\n"
Expand Down

0 comments on commit 8424efc

Please sign in to comment.