Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the recent plugins PR #334 , I accidentally broke in-tree builds. The problem was the directory/path logic, which set plugin paths to be relative to the top-level
CMakeLists.txt
file. In fact it should be relative to the project source directory forsingularity-eos
specifically. This almost trivial change fixes that.PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following: