Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in-tree builds #340

Merged
merged 2 commits into from
Feb 11, 2024
Merged

fix in-tree builds #340

merged 2 commits into from
Feb 11, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Feb 10, 2024

PR Summary

In the recent plugins PR #334 , I accidentally broke in-tree builds. The problem was the directory/path logic, which set plugin paths to be relative to the top-level CMakeLists.txt file. In fact it should be relative to the project source directory for singularity-eos specifically. This almost trivial change fixes that.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

@Yurlungur Yurlungur added bug Something isn't working build Something to do with the build system labels Feb 10, 2024
@Yurlungur Yurlungur self-assigned this Feb 10, 2024
@AstroBarker
Copy link
Collaborator

Thanks for the fix @Yurlungur! LGTM

@Yurlungur Yurlungur merged commit bb8cf53 into main Feb 11, 2024
4 checks passed
@Yurlungur Yurlungur deleted the jmm/fix-plugins-for-in-tree branch February 11, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Something to do with the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants