Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation #349

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix typo in documentation #349

merged 1 commit into from
Feb 23, 2024

Conversation

jhp-lanl
Copy link
Collaborator

PR Summary

Fixes a small typo in the closure model documentation

PR Checklist

  • N/A Adds a test for any bugs fixed. Adds tests for new features.
  • N/A Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • N/A Make sure the copyright notice on any files you modified is up to date.
  • N/A After creating a pull request, note it in the CHANGELOG.md file.
  • N/A LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • N/A Update the version in cmake.
  • N/A Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

@jhp-lanl jhp-lanl requested a review from aematts February 23, 2024 00:45
Copy link
Collaborator

@aematts aematts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

@jhp-lanl
Copy link
Collaborator Author

Thanks for the approval @aematts ! To my eye this looks good so I'll merge it in.

Screenshot 2024-02-22 at 6 33 43 PM

FYI @jonahm-LANL since I think you wrote this

@jhp-lanl jhp-lanl merged commit caa7ae4 into main Feb 23, 2024
4 checks passed
@jhp-lanl jhp-lanl deleted the jhp/fix_doc branch February 23, 2024 01:34
@aematts
Copy link
Collaborator

aematts commented Feb 23, 2024 via email

@Yurlungur
Copy link
Collaborator

Yeah I wrote this and this is fix is correct. Thanks for the fix!

@aematts
Copy link
Collaborator

aematts commented Feb 23, 2024

I found one more place that needs to be updated: You have rho without bar in the The Density-Temperature Formulation section too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants