Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Sulfuras' sellIn value to 0 on sell date #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javi-dev
Copy link

This was the exact same test as the one preceding it (a copy and paste problem, I guess). It doesn't really matter in the end, because (spoiler) Sulfuras' tick() method doesn't do anything at all.

I noticed it as I paused the video and was reading the spec on my own, it could be confusing to a beginner.

Really fun working along with you on this one. Thanks!

This was the exact same test as the one preceding it. It doesn't really
matter in the end, because Sulfuras' tick() doesn't do anything at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant