Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(censys): update module #1556

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

thehappydinoa
Copy link
Contributor

Closes #1468

@thehappydinoa
Copy link
Contributor Author

Looks like there is a conflict here:

The conflict is caused by:
    censys 2.2.6 depends on urllib3<3.0.0
    pyppeteer 1.0.2 depends on urllib3<2.0.0 and >=1.25.8
    requests 2.31.0 depends on urllib3<3 and >=1.21.1
    types-requests 2.31.0.7 depends on urllib3>=2

I can make the pinned version of types-requests less demanding.

@thehappydinoa thehappydinoa force-pushed the adh/update-censys-module branch from 237a1b1 to 190dd21 Compare October 2, 2023 14:04
@thehappydinoa
Copy link
Contributor Author

Now it is erroring out on the following module: otxsearch

@L1ghtn1ng
Copy link
Collaborator

I am getting no results at all for any domain that I try

@L1ghtn1ng
Copy link
Collaborator

@thehappydinoa seems something is still not working correctly

@thehappydinoa
Copy link
Contributor Author

Thats so strange, what error are you encountering?

@L1ghtn1ng
Copy link
Collaborator

L1ghtn1ng commented Oct 8, 2023 via email

@L1ghtn1ng L1ghtn1ng merged commit b1a67c8 into laramies:master Oct 18, 2023
3 of 7 checks passed
@L1ghtn1ng
Copy link
Collaborator

@thehappydinoa have merged it as it should improve things but but was not working for me but will check again, but if you would not mind checking on your end that would be greatly appreciated. I was not getting any errors at all and from looking in the dashboard getting no hits on my api key either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Censys needs porting to the new api version
2 participants