Payment method as array

[chris-redbeed]

I replace the comma string with an array.
The comma string don't work and the Class only allowed stings.

With this changes it is possible to set up multiple method correctly.

[sandervanhooft]

A lot of people will be using the current default config for this, so we'll need to provide something that's backwards compatible.

When processing the method from the config, how about:

If null: convert to empty array []
If string: remove spaces, explode(',')

Then process the array.

[sandervanhooft]

Almost there :), see my review comments.

Also, don't forget to add a unit test for the trait.

Please test these cases:

$method = ' , ideal    , bancontact '; // results in ['ideal', 'bancontact']
$method = null; // results in []

[mmachatschek]

Please see my comments in #203. The Billable trait needs to be updated too, in order to correctly work with the updated firstPaymentMethod return value in this PR, which now is a array instead of a string

I'm specifically pointing to line 78 in Billable::class

[chris-redbeed]

@sandervanhooft FYI: Currently I didn't run the unit tests because I need to set up a test env. with the mandatory IDs (Payment IDs, Customer IDs) for the test. I will let you know after I run the tests.

[sandervanhooft]

Please see my comments in #203. The Billable trait needs to be updated too, in order to correctly work with the updated firstPaymentMethod return value in this PR, which now is a array instead of a string

I'm specifically pointing to line 78 in Billable::class

Not sure I get your point. Can you elaborate on this?

[sandervanhooft]

Please see my comments in #203. The Billable trait needs to be updated too, in order to correctly work with the updated firstPaymentMethod return value in this PR, which now is a array instead of a string
I'm specifically pointing to line 78 in Billable::class

Not sure I get your point. Can you elaborate on this?

All cleared up now in #203.

[sandervanhooft]

• Currently, the PlanContract states that method should return a string. People are relying on this, so we should keep this compatible.

• Also, the FirstPaymentBuilder::getMolliePayload is now returning a Collection instance instead of an array.

[sandervanhooft]

Let's treat this as a breaking change (BC) and adopt it in v2.

This also means we can simplify it further by changing everything into array, no need for backwards compatibility.

[salmanhijazi]

How to bypass this for now to allow multiple methods?

[sandervanhooft]

Merged into v2-develop, thanks @chris-redbeed !