Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.x improve resend transport response handling - fix #54006

Conversation

markovic-nikola
Copy link
Contributor

Additional fix for the already closed PR: #54004
After @jayanratna pointed out that successful API call doesn't have status code included.

Sorry for the extra work.

@jayanratna
Copy link
Contributor

Just had a look at the Resend PHP SDK and it looks like I need to update the error list to catch the daily quota error. This is probably why you're having to add this logic in first place.

@jayanratna
Copy link
Contributor

I have created this PR (resend/resend-php#64) to update the Resend error list. This should allow the daily_quota_exceeded error to be correctly handled.

Currently getting it reviewed by the Resend team.

@markovic-nikola
Copy link
Contributor Author

Thanks for the help!
I'll leave it to the Laravel team to decide whether to keep this PR as a 'fallback' solution or to revert it altogether.

@taylorotwell taylorotwell merged commit 6c9e29f into laravel:11.x Dec 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants