Skip to content

Commit

Permalink
Merge pull request #773 from laravel/fix/versioning
Browse files Browse the repository at this point in the history
[2.x] Validates if there is a version before using it
  • Loading branch information
nunomaduro authored Dec 19, 2023
2 parents 9cfbdf4 + 9c04a45 commit 4bf1855
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Commands/Concerns/InstallsFrankenPhpDependencies.php
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ protected function ensureFrankenPhpBinaryMeetsRequirements($frakenPhpBinary)

$version = explode(' ', $version)[1] ?? null;

if ($version === null) {
if ($version === null || preg_match('/\d+\.\d+\.\d+/', $version) !== 1) {
return $this->warn(
'Unable to determine the current FrankenPHP binary version. Please report this issue: https://github.com/laravel/octane/issues/new.',
);
Expand Down

0 comments on commit 4bf1855

Please sign in to comment.