Fix for up/down arrows + cursor position when textarea content contains multi-byte strings #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
reviewed
Apr 17, 2024
…enbaum/prompts into bugfix/textarea-cursor-multibyte
jessarcher
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #133.
When the content of the textarea contains a multi-byte string, we need to count the characters in the content, not measure the width of the string to determine the cursor position.
By using
count(mb_str_split($content))instead ofmb_strwidth($content), we are able to more accurately place the cursor where it belongs whether or not the content contains multi-byte strings.